[Remote Store] Update Translog Metadata file name #8350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
force-pushed
the
new-metadata-format
branch
from
1db2b68 to
0c29a67
Compare
gbbafna
changed the title
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
force-pushed
the
new-metadata-format
branch
from
0c29a67 to
3931db0
Compare
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
force-pushed
the
new-metadata-format
branch
from
3931db0 to
7acb962
Compare
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
reviewed
Jul 3, 2023
server/src/main/java/org/opensearch/index/remote/RemoteStoreUtils.java
Outdated
Show resolved
Hide resolved
Bukhtawar
reviewed
Jul 3, 2023
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Outdated
Show resolved
Hide resolved
Bukhtawar
reviewed
Jul 3, 2023
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Outdated
Show resolved
Hide resolved
gbbafna
force-pushed
the
new-metadata-format
branch
2 times, most recently
from
1d519b7 to
5c5c85f
Compare
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
requested review from
reta,
anasalkouz,
andrross,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan and
saratvemulapalli
as code owners
gbbafna
force-pushed
the
new-metadata-format
branch
2 times, most recently
from
e512bb1 to
6991096
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
sachinpkale
force-pushed
the
new-metadata-format
branch
2 times, most recently
from
194262a to
c80a390
Compare
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
approved these changes
Jul 7, 2023
ashking94
approved these changes
Jul 7, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8350-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed38fa28a96e111bf12e04c67847c2396151fe19
# Push it to GitHub
git push --set-upstream origin backport/backport-8350-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
added a commit
to gbbafna/OpenSearch
that referenced
this pull request
Jul 8, 2023
…#8350) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
sachinpkale
pushed a commit
that referenced
this pull request
Jul 8, 2023
vikasvb90
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
…#8350) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
raghuvanshraj
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
…#8350) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dzane17
pushed a commit
to dzane17/OpenSearch
that referenced
this pull request
Jul 12, 2023
…#8350) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
buddharajusahil
pushed a commit
to buddharajusahil/OpenSearch
that referenced
this pull request
Jul 18, 2023
…#8350) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…#8350) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…#8350) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are changing translog metadata file name to
<inverted_primary_term>-- <inverted_generation>--<inverted_timestamp>--
This would enable us to use lexicographic sort given by remote stores and find the latest metadata in just one list call, instead of doing pagination .
With this change, we are also deleting the older metadata files with every cleanup operation.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.